Github user skavulya commented on the issue:
https://github.com/apache/flink/pull/1985
Thanks @tillrohrmann!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/1985
The PR looks good to me. Thanks a lot for your contribution @skavulya. I
will merge this PR once the rebased code passes Travis :-)
---
If your project is set up for it, you can reply to this
Github user mtunique commented on the issue:
https://github.com/apache/flink/pull/1985
Could this PR be merged ? Maybe this PR blocks to design
GLM([FLINK-2013](https://issues.apache.org/jira/browse/FLINK-2013)).
---
If your project is set up for it, you can reply to this email and
Github user skavulya commented on the issue:
https://github.com/apache/flink/pull/1985
hi @chiwanpark sorry, I hadn't checked this PR for a while. I merged the
latest master. Do you have any preference on an alternative name for
RegularizationPenalty? Would Regularizer work better?
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/1985
Hi @skavulya, sorry for late response. I've checked the updated PR and
looks good to me. I wonder whether the name `RegularizationPenalty` is proper
because the class calculates lots of values.
Github user skavulya commented on the issue:
https://github.com/apache/flink/pull/1985
@chiwanpark The PR is ready. Let me know if I need to do anything else.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user skavulya commented on the issue:
https://github.com/apache/flink/pull/1985
@chiwanpark Decoupling the gradient descent step is complicated for L1
regularization because we are using the proximal gradient method that applies
soft thresholding after executing the gradient
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/1985
Okay, please ping me when the PR is updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user skavulya commented on the issue:
https://github.com/apache/flink/pull/1985
While working on L-BFGS, I realized that I need to remove the gradient
descent step from RegularizationPenalty. I'll update the PR soon.
---
If your project is set up for it, you can reply to this
Github user skavulya commented on the issue:
https://github.com/apache/flink/pull/1985
Thanks @chiwanpark. I made the changes you recommended. Please let me know
if it looks ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
10 matches
Mail list logo
