[GitHub] flink issue #1989: FLINK-3901 - Added CsvRowInputFormat

2016-07-22 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/1989 Ok for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #1989: FLINK-3901 - Added CsvRowInputFormat

2016-07-22 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/1989 @fpompermaier I think you can close this PR. I will take your commit, put the Scala conversion on top of it and open a new PR. --- If your project is set up for it, you can reply to this email and

[GitHub] flink issue #1989: FLINK-3901 - Added CsvRowInputFormat

2016-07-21 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/1989 Don't worry @twalthr, it will be nice to have it in the 1.1 but I understand that it's not a priority :) Thanks a lot for the update! --- If your project is set up for it, you can reply to

[GitHub] flink issue #1989: FLINK-3901 - Added CsvRowInputFormat

2016-07-21 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/1989 @fpompermaier I started working on this, but I can not guarantee that it will be part of the release. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #1989: FLINK-3901 - Added CsvRowInputFormat

2016-07-19 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/1989 Hi @twalthr, any news about this? Are you going to merge this PR in the upcoming 1.1 release? If you were waiting for a feedback you have my +1 about your strategy..go ahead and convert the

[GitHub] flink issue #1989: FLINK-3901 - Added CsvRowInputFormat

2016-07-11 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/1989 I would assign FLINK-4081 to me and try to fix it this week. I also think that a mixed project makes development more complicated. I scanned through your code. Maybe you could convert the 143 lines

[GitHub] flink issue #1989: FLINK-3901 - Added CsvRowInputFormat

2016-06-15 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/1989 Hi @fpompermaier, thanks for the PR. The `flink-table` module is almost completely implemented in Scala. We do not have good experience with mixed Scala / Java modules and I would like to ask if you