[GitHub] flink issue #2007: [FLINK-3908] Fixed Parser's error state reset
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2007 Merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2007: [FLINK-3908] Fixed Parser's error state reset
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2007 I'm not sure; in any case it should not be removed as part of this PR. You can open a separate JIRA or ask on the mailing list. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2007: [FLINK-3908] Fixed Parser's error state reset
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2007 Now it should be ok, according to your suggestions. I misunderstood what @StephanEwen was trying to say, thanks @zentol for the clarification! Just another thing: the method GenericCsvInputFormat.checkAndCoSort() is never used in the code. Do you want to keep it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2007: [FLINK-3908] Fixed Parser's error state reset
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2007 then make parseField protected so users MUST call resetErrorStateAndParse. there, problem solved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2007: [FLINK-3908] Fixed Parser's error state reset
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2007 I think that leaving the responsibility of calling resetErrorStateAndParse() to "consumers" of FieldParser is really a bad idea. Isn't safer to force its call using the strategy adopted in this PR (i.e. keep the real implementation in parseFieldImpl and use parseField to call resetErrorStateAndParse before it)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
