[GitHub] flink issue #2120: [FLINK-4070] [tableApi] Support literals on left side of ...

2016-07-20 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2120 Yes I think renaming makes sense as we both didn't find the method at first glance. I will finalize your PR so that it will be included in the release. --- If your project is set up for it, you can

[GitHub] flink issue #2120: [FLINK-4070] [tableApi] Support literals on left side of ...

2016-07-04 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2120 Hi @twalthr , I find that `expr` in `expressionDsl.scala` has done what we want. As we can do like this: `12.expr % 'f0` or `12 * 'f0.expr`. So do we need this PR just rename `expr` to