[GitHub] flink issue #2182: [Flink-4130] CallGenerator could generate illegal code wh...

2016-07-19 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2182 Thanks for the contribution @unsleepy22. I changed the code a little bit, so that we can prevent an `if(false)` branch. Will merge... --- If your project is set up for it, you can

[GitHub] flink issue #2182: [Flink-4130] CallGenerator could generate illegal code wh...

2016-06-29 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2182 Yah... the `isNull$17` is not declared if we do what I said above, and of course will throw compile error. The code looks good to me now, although it looks a little weird that

[GitHub] flink issue #2182: [Flink-4130] CallGenerator could generate illegal code wh...

2016-06-29 Thread unsleepy22
Github user unsleepy22 commented on the issue: https://github.com/apache/flink/pull/2182 @wuchong although I agree this bug could be fixed by adding `operands.nonEmpty`, there is a problem in generated code, specifically, an undeclared variable will be generated like this: ```