[GitHub] flink issue #2304: [FLINK-4268] [core] Add parsers for BigDecimal/BigInteger

2016-09-20 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2304 Thanks again for the review @fhueske. I will fix your comments and merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #2304: [FLINK-4268] [core] Add parsers for BigDecimal/BigInteger

2016-09-19 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2304 @fhueske I improved the big decimal parsing. Now less objects are created. I hope I didn't introduce new bugs. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #2304: [FLINK-4268] [core] Add parsers for BigDecimal/BigInteger

2016-08-19 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2304 Thanks @twalthr, PR looks good. Only added a hint how String creations can be avoided. Good to merge otherwise. --- If your project is set up for it, you can reply to this email and