Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2388
Auto-closing from a commit doesn't in the feature branch. Could you please
close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2388
Thank you for your work @KurtYoung. Merging the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2388
Hi @KurtYoung! Let me also go over your changes and then merge this as part
of the new ResourceManager.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2388
Yes, this is for ResourceManager
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2388
Just to avoid doubt: This should run as part of the ResourceManager,
correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2388
I think i shall do the resolving thing.
The commits are squashed and conflicts been resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2388
Looks quite good all in all.
Be good to get this in, so that JobManager followup work can build on this.
I would take this, rebase it, and merge it. If I find some issues I would
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2388
I am taking a look at this now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/2388
hi @tillrohrmann , thanks for the reviewing, all your comments will be
addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
