Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2414
Thanks @rmetzger !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2414
Thank you for the pull request. I'll merge it to master and the release-1.1
branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2414
@rmetzger, @aljoscha the changes are ready for another review now, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2414
To include the missing case @rmetzger mentioned, it turns out the fix is
actually more complicated than I expected due to correct state determination
after every reshard, and requires a bit of
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2414
Minus @rmetzger's comment this looks good to merge! Thanks for fixing this
@tzulitai!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2414
Ah yes, correct. I'll update this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2414
Thank you for opening a pull request to fix the issue.
I think we also need to cover another case: What happens when the number of
shards has been reduced in a resharding and some fetchers
