[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 #3037 has merged. done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2439 Please close this since there is a newer PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 @StephanEwen I use new githup account make a new pull request #3037, help me to review it please.Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 @StephanEwen Sorry, I can't continue with this pull request. I will use another githup account to pull. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 Sorry, something was wrong when I am rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2439 Thanks! You can squash commits by rebasing. Have a look here: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 Complie error is fixed. But how to squash all commits into one commit? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 Fixed complie error. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2439 I think this is getting into good shape, we can almost merge it. Two things remaining: 1. Can you rebase/squash all commits into one commit? 2. There is a complilation error, probably a missing dependency, see below. Hope that when those are addresses, we can merge this. ``` [INFO] - [ERROR] COMPILATION ERROR : [INFO] - [ERROR] /home/travis/build/apache/flink/flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkSubmitter.java:[30,23] package org.json.simple does not exist [INFO] 1 error [INFO] - ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 @StephanEwen Fixed. Help me to review it please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 Sorry.forget to check it. I will do it tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2439 I would like to merge this. But I think we need to change back the dependency exclusions in `flink-storm/pom.xml` to as they are in the current master. Can you do that? Then I will merge this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2439 Okay, then we should re-add all the dependency exclusions that were removed from the `flink-storm/pom.xml`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 @StephanEwen Actually, I'm not very clear about Clojure Web FrameWork, but it's web framework are using "ring.ring-core". import: https://github.com/apache/storm/blob/1.x-branch/pom.xml#L703 code detail: https://github.com/apache/storm/blob/1.x-branch/storm-core/src/clj/org/apache/storm/ui/helpers.clj#L36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 **Jenkins run error** 1.build success ``` [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 01:18 h [INFO] Finished at: 2016-10-09T12:42:31+00:00 [INFO] Final Memory: 210M/1154M ``` 2.finish fail: ``` [JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/flink-github-ci/flink-contrib/flink-streaming-contrib/target/flink-streaming-contrib_2.10-1.2-SNAPSHOT-javadoc.jar to org.apache.flink/flink-streaming-contrib_2.10/1.2-SNAPSHOT/flink-streaming-contrib_2.10-1.2-SNAPSHOT-javadoc.jar channel stopped Putting comment on the pull request Finished: UNSTABLE ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 Jenkins run successful, but CI fail.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 close it, and will open new pull request later --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 @StephanEwen If we merge this, flink-storm will compatible with all the storm which version higher than 1.0.0 And we can import "storm-rename-hack" to compatible with previous storm version. It can change class package name previous storm version jar. see the detail: https://github.com/apache/storm/tree/master/storm-rename-hack --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2439 There is an interesting question about how to proceed with that. If we merge this, the compatibility layer will only support Storm 1.0 programs, which are incompatible with prior versions. I would assume a lot of people have Storm jobs with prior versions. In some sense we would need two compatibility projects, one for Storm pre-1.0 and one for Storm post-1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 Jenkins run error: ``` Running org.apache.flink.test.checkpointing.PartitionedStateCheckpointingITCase SUREFIRE-859: Java HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0xd8b0, 100663296, 0) failed; error='Cannot allocate memory' (errno=12) # # There is insufficient memory for the Java Runtime Environment to continue. # Native memory allocation (mmap) failed to map 100663296 bytes for committing reserved memory. # An error report file with more information is saved as: # /home/jenkins/jenkins-slave/workspace/flink-github-ci/flink-tests/target/hs_err_pid9818.log Running org.apache.flink.test.checkpointing.WindowCheckpointingITCase ERROR: Maven JVM terminated unexpectedly with exit code 137 Putting comment on the pull request Finished: FAILURE ``` But I run it successfully in my environment, does it a Jenkins memory problem? Rerun it in Jenkins? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 mvn clean verify : ok test flink-storm-examples: ok bin/flink run WordCount-StormTopology.jar bin/flink run WordCount-BoltTokenizer.jar bin/flink run WordCount-SpoutSource.jar --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
