Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2457
Merging this ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2457
Would be cool if we could also merge this to `release-1.1` if it is good to
merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2457
@iampeter @greghogan I've update the PR according to your review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user iampeter commented on the issue:
https://github.com/apache/flink/pull/2457
@greghogan right - missed the generated files. @mushketyk I suppose
`gulp`ing will help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2457
1) `JsonPlanGenerator.java:55` should be reverted to use `NOT_SET`.
2) `index.js` is changing jobServer from the empty string to
'http://localhost:8081/'.
3) `vendor.js` is upgrading the
Github user iampeter commented on the issue:
https://github.com/apache/flink/pull/2457
@mushketyk from my side looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2457
Hi @iampeter
I've updated the PR according to you suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2457
Hi @greghogan
I've fixed the code according to your suggestion.
Could you give it another look?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2457
@iampeter
Did you have a chance to take a look at this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
