[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7

Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2458 @StephanEwen OK. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2458 From my side, this is good to merge. Unless someone objects, I will merge this later today... --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7

Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2458 enforce java 7 before compile. There is no conflict between source/target and enforcer java version. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2458 We already gave up Java 6, and setting the source and target version in the Maven compiler plugin already prevents Java 6 usage. That is why I am wondering... --- If your project is set up for

[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7

Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2458 @greghogan exactly 3.0.3 will be OK. This limit is some module require, I forget where it is, I am sorry.. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7

Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2458 Would this be useful to prevent building Flink with Maven 3.3.x? https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html https://maven.apache.org/enforcer/enforcer-rules/

[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7

Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2458 hi, @StephanEwen There are much difference between JDK 6 and JDK 7+. It's better for compatible low version JDK，but there are better performance for Scala with Lambda support, and JDK 7

[GitHub] flink issue #2458: [FLINK-4560] enforcer java version as 1.7

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2458 Hi! Can you explain a bit what this pull request fixes? I think Maven complains by itself if the JDK is of a lower version than the compiler target version. So what changes here?