[GitHub] flink issue #2472: [FLINK-4361] Introduce Flink's own future abstraction

2016-09-21 Thread tillrohrmann
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/2472
  
Thanks for the review @KurtYoung, @mxm and @StephanEwen. I will merge this 
PR to the flip-6 branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #2472: [FLINK-4361] Introduce Flink's own future abstraction

2016-09-20 Thread StephanEwen
Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/2472
  
The naming is not super nice, I agree. But there is a clear benefit for 
Java 8 familiar people to stick with something established.

+1 for this from my side.

Next time we get involved in the Java community processes, to make sure 
they have better names ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #2472: [FLINK-4361] Introduce Flink's own future abstraction

2016-09-20 Thread tillrohrmann
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/2472
  
Thanks for your review @KurtYoung. Will address your comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---