[GitHub] flink issue #2482: [FLINK-4579] [StateBackend] Add StateBackendFactory for R...

2016-10-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2482 Looks good, thanks! Rebasing and merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #2482: [FLINK-4579] [StateBackend] Add StateBackendFactory for R...

2016-09-23 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2482 Added a shortcut (rocksdb) for configuring RocksDB state backend and added the dedicated option config `state.backend.rocksdb.checkpointdir`. --- If your project is set up for it, you can reply to

[GitHub] flink issue #2482: [FLINK-4579] [StateBackend] Add StateBackendFactory for R...

2016-09-22 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2482 Good point. I think reflect is good, if it does not add too much work. Keeping the modules separate is nice, I think. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #2482: [FLINK-4579] [StateBackend] Add StateBackendFactory for R...

2016-09-19 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2482 Hi @StephanEwen , if we want to have a shortcut (`rocksdb`), what should we do? Add the rocksdb dependency into `flink-streaming-java` module ? Or use java reflect ? --- If your project is set

[GitHub] flink issue #2482: [FLINK-4579] [StateBackend] Add StateBackendFactory for R...

2016-09-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2482 Looks good. I think we could even go one step further and have a shortcut (`rocksdb`) similar to `filesystem` and `jobmanager`. We should then also have dedicated options, like