[GitHub] flink issue #2539: [FLINK-4668] Fix positive random int generation

2016-09-23 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2539 Yes, looks good to me, too. (I retract my earlier statement, I was apparently a bit tired and mixed up original version and edit). --- If your project is set up for it, you can reply to

[GitHub] flink issue #2539: [FLINK-4668] Fix positive random int generation

2016-09-23 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2539 These are temporary files automatically deleted by the client. To handle paths with leading dashes one can prefix with a directory (`vi ./-44.txt`) or place after a double dash (`vi -- -44.txt`).

[GitHub] flink issue #2539: [FLINK-4668] Fix positive random int generation

2016-09-23 Thread apivovarov
Github user apivovarov commented on the issue: https://github.com/apache/flink/pull/2539 it's not even convenient to work with files started with `-`, e.g. ```$ vi -44.txt VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Aug 1 2016 19:37:21) Unknown option argument: "-44.txt"

[GitHub] flink issue #2539: [FLINK-4668] Fix positive random int generation

2016-09-23 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2539 I don't think this fixes a bug since I'm not aware of filesystems unable to handle a leading dash. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #2539: [FLINK-4668] Fix positive random int generation

2016-09-23 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2539 I think this is not necessary. `Random.nextInt(int)` returns only positive values. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as