Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2580
Merging this to master now ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2580
Merging this once tests turn green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2580
Thanks for the review @rmetzger. I've created several local branches to
test out the new IT tests stability as @StephanEwen suggested, and they seem to
be fine.
I'll rebase this, address
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2580
Thanks for the review @StephanEwen.
Concerning changing the contract for `commitSpecificOffsetsToKafka`:
Makes sense, I don't really like excessive copying too. With proper tests
on
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2580
Looks quite good. I would suggest one change, though:
Can we avoid copying the offsets in the checkpoint into a new map (with
increment by one) and passing that to the ZooKeeper Offset
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2580
Seems like one of the new IT tests is a bit unstable, fixing it ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
