Github user mproch commented on the issue:
https://github.com/apache/flink/pull/2629
@bjlovegithub @tillrohrmann thanks for quick reply :+1: I really
appreciate your work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bjlovegithub commented on the issue:
https://github.com/apache/flink/pull/2629
hi @tillrohrmann @mproch I have updated the PR, including a wrapper class
for `RuntimeContext` specialized for `RichAsyncFunction`.
---
If your project is set up for it, you can reply to this
Github user bjlovegithub commented on the issue:
https://github.com/apache/flink/pull/2629
Hi @tillrohrmann . I have updated the PR. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2629
Great to hear @bjlovegithub :-) Ping me once you've pushed some new commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bjlovegithub commented on the issue:
https://github.com/apache/flink/pull/2629
Hi @tillrohrmann Thanks for your help. I am still working on it, adding
more test cases and modifying its internal data structure. It almost has been
done. But due to other jobs, I can not work
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2629
Hi @bjlovegithub, just wanted check whether I can help you with anything to
complete this PR and get it merged. If that's the case, then let me know.
---
If your project is set up for it, you
Github user bjlovegithub commented on the issue:
https://github.com/apache/flink/pull/2629
Hi @tillrohrmann . I have updated the code again, adding the Emitter
Thread, using the latest OperatorStateStore, updating the test codes. Thanks
---
If your project is set up for it, you can
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2629
The `AsyncCollectorBufferTest.testAdd` fails with a `NullPointerException`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2629
The `notifyCheckpointComplete` will mitigate the problem of adding latency
a little bit but not get rid of it because the tasks are only notified about a
completed checkpoint if the whole
Github user bjlovegithub commented on the issue:
https://github.com/apache/flink/pull/2629
Maybe this is a solution. We will not think about changing the type of
`checkpointLock`, which is an `Object` ans quite efficient, and not change the
order of `broadcastBarriers` and
Github user bjlovegithub commented on the issue:
https://github.com/apache/flink/pull/2629
Good point ;D
Emm, I think we have to override the
`StreamOpeartor.notifyCheckpointComplete()` for `AsyncWaitOpeartor` so that
once the `TaskManager` notifies the `Task` that
Github user bjlovegithub commented on the issue:
https://github.com/apache/flink/pull/2629
The case may happen when all elements have arrived. For this case,
`StreamTask` will go to close all operators, which will reach
`AsyncCollectorBuffer.waitEmpty`. In this function, `Emitter
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2629
Ah, I think now I understand. Upon checkpointing you disable the output
emission. The emission can only be reactivated when adding a `StreamRecord`, a
`Watermark` or a `LatencyMarker` to the
Github user bjlovegithub commented on the issue:
https://github.com/apache/flink/pull/2629
For exactly once processing guarantees, when
`AsyncCollectorBuffer.getStreamElementsInBuffer` has finished,
`isCheckpointing` will be set to true, while will idle `Emitter Thread` while
Github user bjlovegithub commented on the issue:
https://github.com/apache/flink/pull/2629
For exactly once processing guarantees, when
`AsyncCollectorBuffer.getStreamElementsInBuffer` has finished,
`isCheckpointing` will be set to true, while will idle `Emitter Thread` while
Github user bjlovegithub commented on the issue:
https://github.com/apache/flink/pull/2629
For exactly once processing guarantees, when
`AsyncCollectorBuffer.getStreamElementsInBuffer` has finished,
`isCheckpointing` will be set to true, while will idle `Emitter Thread` while
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2629
The combination of `UNORDERED` with event time is not strictly meaningless.
The only thing which one has to do respect is that only those elements in the
queue from the beginning to the first
Github user bjlovegithub commented on the issue:
https://github.com/apache/flink/pull/2629
Hi @tillrohrmann , Thanks for your review ;D I will check through each of
your comments and update the PR later.
Coming to the first part of review, the first one is about `UNORDERED` mode
Github user bjlovegithub commented on the issue:
https://github.com/apache/flink/pull/2629
Update the PR based on the latest review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
19 matches
Mail list logo
