[GitHub] flink issue #2829: [hotfix] prevent RecordWriter#flush() to clear the serial...

Github user uce commented on the issue: https://github.com/apache/flink/pull/2829 Thanks for addressing the comments, Nico. Going to merge this with the next batch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #2829: [hotfix] prevent RecordWriter#flush() to clear the serial...

Github user NicoK commented on the issue: https://github.com/apache/flink/pull/2829 I put a bit more emphasis on that fact in the new docs. I'd say, that's enough and after reading the docs, the difference should be clear. --- If your project is set up for it, you can reply to this

[GitHub] flink issue #2829: [hotfix] prevent RecordWriter#flush() to clear the serial...

Github user uce commented on the issue: https://github.com/apache/flink/pull/2829 Good additions with the Javadocs. All changes looks good to me. --- While looking over the Serializer interface I noticed that `clear` and `clearCurrentBuffer` are dangerously similar. But

[GitHub] flink issue #2829: [hotfix] prevent RecordWriter#flush() to clear the serial...

Github user NicoK commented on the issue: https://github.com/apache/flink/pull/2829 I don't expect this to change any behaviour as clearing the serializer twice does actually not hurt and is only some waste of resources so FLINK-4719 should not be affected at all --- If your