[GitHub] flink issue #2838: [FLINK-4712] [FLINK-4713] [ml] Ranking recommendation & e...

2016-11-25 Thread thvasilo
Github user thvasilo commented on the issue: https://github.com/apache/flink/pull/2838 > The problem is not with the evaluate(test: TestType): DataSet[Double] but rather with evaluate(test: TestType): DataSet[(Prediction,Prediction)]. Completely agree there, I advocated for

[GitHub] flink issue #2838: [FLINK-4712] [FLINK-4713] [ml] Ranking recommendation & e...

2016-11-24 Thread gaborhermann
Github user gaborhermann commented on the issue: https://github.com/apache/flink/pull/2838 Thanks again for taking a look at our PR! I've just realized from a developer mailing list thread that the FlinkML API is still not carved into stone even until 2.0, and it's nice to

[GitHub] flink issue #2838: [FLINK-4712] [FLINK-4713] [ml] Ranking recommendation & e...

2016-11-23 Thread gaborhermann
Github user gaborhermann commented on the issue: https://github.com/apache/flink/pull/2838 Hello Theodore, Thank you for checking out our solution! I would not like to answer now, as we did most of the work together with @proto-n, and I might be wrong in some aspects. I'll

[GitHub] flink issue #2838: [FLINK-4712] [FLINK-4713] [ml] Ranking recommendation & e...

2016-11-23 Thread thvasilo
Github user thvasilo commented on the issue: https://github.com/apache/flink/pull/2838 Hello Gabor, I like the idea of having a RankingScore, it seems like having that hierarchy with Score, RankingScore and PairWiseScore gives us the flexibility we need to include ranking

[GitHub] flink issue #2838: [FLINK-4712] [FLINK-4713] [ml] Ranking recommendation & e...

2016-11-21 Thread gaborhermann
Github user gaborhermann commented on the issue: https://github.com/apache/flink/pull/2838 Hi @thvasilo, of course, thanks for taking a look! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #2838: [FLINK-4712] [FLINK-4713] [ml] Ranking recommendation & e...

2016-11-21 Thread thvasilo
Github user thvasilo commented on the issue: https://github.com/apache/flink/pull/2838 Hello @gaborhermann, thanks for making the PR! I'll try to take a look this week, I've been busy with a couple of other PRs these days. --- If your project is set up for it, you can