[GitHub] flink issue #2857: [FLINK-5146] Improved resource cleanup in RocksDB keyed s...

2016-12-03 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/2857 Thanks for the reviews and merging, @aljoscha @tillrohrmann . Closing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #2857: [FLINK-5146] Improved resource cleanup in RocksDB keyed s...

2016-12-03 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2857 Thanks for your work: 👍 I merged it, could you please close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #2857: [FLINK-5146] Improved resource cleanup in RocksDB keyed s...

2016-11-25 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/2857 I introduced the planned change to the test. You could take another look if you want :-) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #2857: [FLINK-5146] Improved resource cleanup in RocksDB keyed s...

2016-11-23 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/2857 This was a preliminary PR, so that people can already take a look. However, I think besides one sleep in a test, the added value is already enough to have this in. Leftover todos can go to a

[GitHub] flink issue #2857: [FLINK-5146] Improved resource cleanup in RocksDB keyed s...

2016-11-23 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2857 Overall, the changes and the tests look very good. There are some `TODO`s left in the code, what about those? --- If your project is set up for it, you can reply to this email and have your reply