[GitHub] flink issue #2982: [FLINK-4460] Side Outputs in Flink

Github user jgrier commented on the issue: https://github.com/apache/flink/pull/2982 Nice :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #2982: [FLINK-4460] Side Outputs in Flink

Github user chenqin commented on the issue: https://github.com/apache/flink/pull/2982 Wow, finally in! It was fun and thanks for you help along every step of the journey! Chen --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #2982: [FLINK-4460] Side Outputs in Flink

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2982 @chenqin I finally merged it. Could you please also close this PR? And thanks again for working on this for so long! 👍 --- If your project is set up for it, you can reply to this email

[GitHub] flink issue #2982: [FLINK-4460] Side Outputs in Flink

Github user chenqin commented on the issue: https://github.com/apache/flink/pull/2982 @aljoscha Nice! Let's do "Chen Qin qinnc...@gmail.com" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #2982: [FLINK-4460] Side Outputs in Flink

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2982 @chenqin Would you like your commits to be attributed to "Chen Qin " or "Chen Qin "? I see both in your set of commits? I'm finally putting everything

[GitHub] flink issue #2982: [FLINK-4460] Side Outputs in Flink

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2982 Thanks for looking at that! I'll open a new discussion thread on the Mailing lists to discuss Side Outputs and split/select and how we're going to proceed with that. Regarding your other

[GitHub] flink issue #2982: [FLINK-4460] Side Outputs in Flink

Github user chenqin commented on the issue: https://github.com/apache/flink/pull/2982 @aljoscha Looks good to me 👍 I briefly looked at your git branch, a minor comment would be adding comments to `sideOutputLateData` so user get better idea when they opt-in to late

[GitHub] flink issue #2982: [FLINK-4460] Side Outputs in Flink

Github user chenqin commented on the issue: https://github.com/apache/flink/pull/2982 @aljoscha, diff has been updated and merged to support `apply(Function, lateElementsOutput);` `Collector` refactor seems not viable option as stated above. Seems travis-ci

[GitHub] flink issue #2982: [FLINK-4460] Side Outputs in Flink

Github user chenqin commented on the issue: https://github.com/apache/flink/pull/2982 @aljoscha Thanks for your time. We can chat more after 1.2 release! I think it makes sense to extends Collector, even though we may not remove collect(T obj) due to API compability issue in

[GitHub] flink issue #2982: [FLINK-4460] Side Outputs in Flink

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2982 @chenqin I had a quick look at the implementation and it looks quite good. I'll look at it in more detail once the 1.2 release is out and then I'll also have more thorough comments. These

[GitHub] flink issue #2982: [FLINK-4460] Side Outputs in Flink

Github user chenqin commented on the issue: https://github.com/apache/flink/pull/2982 cc @aljoscha --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if