Github user ymarzougui commented on the issue:
https://github.com/apache/flink/pull/2995
Thanks @aljoscha for merging and adding the appropriate tests. Closing the
PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2995
@ymarzougui I finally merged it and added some new unit tests on top
instead of the heavy IT case, I hope that's alright.
Thanks for finding this in the first place and fixing it! ð
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2995
I have some work in the window translation tests that should make testing
this more easy: https://issues.apache.org/jira/browse/FLINK-5237
@StephanEwen what do you think about merging this
Github user ymarzougui commented on the issue:
https://github.com/apache/flink/pull/2995
@StephanEwen @aljoscha, I added a test for `WindowedStream.fold()` similar
to the one in
Github user ymarzougui commented on the issue:
https://github.com/apache/flink/pull/2995
Yes, I will see how to add a unit test and try to add a commit to this PR
by the end of the day or tomorrow. Fortunately the fold in `AllWindowStream` is
correct, the problem in `WindowStream` is
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2995
Thanks a lot, this looks like the correct fix.
Usually, we add a small unit test to such fixes to guard the bugfix.
Also, the same problem probably exists in the `AllWindowStream`.
