Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3040
Thanks for the update @tonycox. I haven't looked at the new changes yet but
just commented on the join. Please let me know if you have further questions.
Thanks, Fabian
---
If your
Github user tonycox commented on the issue:
https://github.com/apache/flink/pull/3040
@fhueske I fixed commented points.
Could you explain the join keys forwarding?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user tonycox commented on the issue:
https://github.com/apache/flink/pull/3040
@fhueske @KurtYoung @twalthr What do you think about this PR ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3040
Yes, it would be good if all user-defined functions have annotations. For
UDFs without generated code, that should be quite simple and might even be
added as a class annotation.
---
If your
Github user tonycox commented on the issue:
https://github.com/apache/flink/pull/3040
Hi,
Do we need field forwarding in `DataSetMinus`, `DataSetIntersect` and
`DataSetSort`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3040
Hi @tonycox, thanks for the notification and picking up this pull request!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tonycox commented on the issue:
https://github.com/apache/flink/pull/3040
Hi,
Nickolay cannot continue work on this PR, so I'm going to try finish it for
him.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3040
I will also take a look at it soon. Unfortunetly, the build failed. Could
you have a look at it? I also recommend to change the `TableProgramsTestBase`
from `TestExecutionMode.COLLECTION` to
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3040
Thanks for the PR @NickolayVasilishin!
I briefly skimmed over the changes and the approach looks OK.
It would be good to have a unit test for `FieldForwardingUtils`.
I'm currently on
