[GitHub] flink issue #3176: [FLINK-5571] [table] add open and close methods for UserD...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3176 Thanks for the update @godfreyhe. I will have a final pass through the code and merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3176: [FLINK-5571] [table] add open and close methods for UserD...
Github user godfreyhe commented on the issue: https://github.com/apache/flink/pull/3176 Thanks for the suggestions @twalthr, I have updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3176: [FLINK-5571] [table] add open and close methods for UserD...
Github user godfreyhe commented on the issue: https://github.com/apache/flink/pull/3176 Hi @wuchong , thanks for this review. I think `UserDefinedScalarFunctionTest` is not enough, because `open` , `close` methods and job parameters are strongly depend on runtime, so it's better to test them in integration tests. I will add a test to verify Java ScalarFunction later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
