Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
> Can we just use the ${project.build.directory} as java.io.tmpdir ?
@wenlong88 Sorry for late reply.
It's good question. If use `${project.build.directory}` without sub
directory `tmp`, th
Github user wenlong88 commented on the issue:
https://github.com/apache/flink/pull/3190
Can we just use the `${project.build.directory}` as `java.io.tmpdir` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
Get it. Run single test, having no temp created, it should use the default
java.io.tmpdir property.
Let me check that.
In the base test class have a double check about the target
---
If y
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3190
Hi! `mvn test` works from the command line.
IntelliJ right-click on a test and run does often not work, it only works
if a console build was done before and the `.../target/tmp/` director
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3190
I agree that we should simply fix the tests; if we do that the proposed
change here is redundant anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3190
@shijinkui This still has the problem that tests don't run any more from
within the IDE. That is a big problem for developers.
As an alternative, we can always fix the tests that do not u
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
hi, @StephanEwen I have re-submit this pull request base on current master
branch which had merged FLINK-5817.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3190
@shijinkui The FileCacheDeleteValidationTest should still be fixed now.
When I tested it, I combined the changed from FLINK-5817 and this pull request.
---
If your project is set up for it, you
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
@StephanEwen The FileCacheDeleteValidationTest had been fixed in
FLINK-5817. This PR have rollback it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3190
Sorry, I have to actually step back on this one.
I merged it into a feature branch and played around a bit with this, and it
turns out it is not possible any more to execute tests from wi
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3190
All right, I am convinced now that this is a helpful change.
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
> Here is a related issue: https://issues.apache.org/jira/browse/FLINK-5817
I sounds good. I want to change the default system property
`java.io.tmpdir` to be in the `target` directory. Thi
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3190
Here is a related issue: https://issues.apache.org/jira/browse/FLINK-5817
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
> The ´${project.build.directory}` is not automatically cleaned up.
The/tmp` directory is natural to clean up.
hi, Stephan, thank for your reply.
When restarting os, tmp dir will
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3190
The ´${project.build.directory}` is not automatically cleaned up. The
`/tmp` directory is natural to clean up.
I would still suggest to simply fix the tests that have no random
director
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
" /tmp/cacheFile (Permission denied)" exception of unit test can be replay.
1. on linux env, `sudo - userA`, clone the flink code, start to `mvn clean
test verify`
2. on the linux machi
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
@greghogan That make sense. Let JUnit to create root dir and delete
temporary dir recursively.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3190
@shijinkui:
[delete](http://junit.org/junit4/javadoc/latest/org/junit/rules/TemporaryFolder.html#delete())
is "usually not called directly, since it is automatically applied by the
Rule".
---
If
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
@StephanEwen I have use TemporaryFolder to replace creating File manually.
There are some tips:
1. TemporaryFolder should invoke `create()` in setup manually
2. in `shutdown()` should in
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3190
@shijinkui I think there are already good temp file utils in JUnit itself.
Do we need to change anything in the build when we fix the tests?
---
If your project is set up for it, you can repl
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
> I would actually prefer to fix the tests, rather than re-assignign the
temp directory. All tests should use a random subdirectory in the temp
directory. It is quite convenient to do via JUnit:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3190
Many tests assume that the `tmp` directory exists.
I would actually prefer to fix the tests, rather than re-assignign the temp
directory. All tests should use a random subdirectory in the
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3190
Travis failed on flink-core:
```
Failed tests:
GenericCsvInputFormatTest.readWithEmptyField:639 Test failed due to a
IOException: No such file or directory
GenericCsvInputForm
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3190
Yes that makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3190
It does if two users build and test from different code directories on the
same machine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3190
I don't see how this could solve the issue in the JIRA; it describes 2
tests from the same module failing since they use the same directory. This PR
doesn't change that.
---
If your project is set u
26 matches
Mail list logo
