Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3302
Thanks @huawei-flink
Looking forward to your contributions!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3302
@fhueske no problem, I understand. It was bad timing, as I was on the run
for more than two weeks, with little time to follow this. We'll contribute on
other issues.
---
If your project is se
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3302
Hi @huawei-flink,
as I said before, there are a few contributions waiting for this patch.
I decided to move one and merge PR #3370.
Thanks a again for working on this and sorry for t
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3302
Hi, it looks like something went wrong when updating the PR.
Can you rebase your changes on the latest master?
Thanks
---
If your project is set up for it, you can reply to this email a
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3302
That would be great @huawei-flink! There are a few contributions waiting
for this addition.
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3302
I managed to merge the changes from PR #3370 into my branch after rebase,
and the test works. I will push the code later today. sorry if I am a little
latent, but I am travelling and connectivit
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3302
Hi Fabian,
I will follow up in the next days, probably early next week. is it ok?
Stefano
---
If your project is set up for it, you can reply to this email and have your
reply
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3302
Hi @huawei-flink, do you plan to follow up on this PR?
Otherwise, I'd merge #3370 after adding a test.
Thanks, Fabian
---
If your project is set up for it, you can reply to this email an
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3302
FYI: #3370 is the commit we use internally for this feature. Please feel
free to take it if it helps implementing this PR.
---
If your project is set up for it, you can reply to this email and have y
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3302
FYI: PR #3252 was just merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3302
Hi @huawei-flink,
thanks for the update! The changes are now pretty much aligned with #3252.
I'm in the process of merging #3252 (running last tests). It would be great if
you could rebase y
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3302
@fhueske I've addressed most of the points, however there is a thing that
is not clear to me yet. So far, the procTime() function generates a timestamp.
My understanding is that this is not corr
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3302
Thanks for reopening the PR!
I made a few comments on #3271 before and after it was closed that should
be addressed.
Thanks, Fabian
---
If your project is set up for it, you can reply
13 matches
Mail list logo
