Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3418
The changes look good to me. However, I also think that such changes should
be part of the PR that actually solve a problem. This PR only adds logic
without a need for it yet.
---
If your project i
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3418
Hmm, I see. I'm usually not in favor of adding code without a clear need.
On the other hand, these changes are not very extensive and I can see how
it might help to code-gen the aggregation funct
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/3418
@fhueske thanks for your review. I have updated the PR.
IMO. The main purpose of doing this PR is to enhance the function of
Flat/MapRunner. In addition, my next plan is:
Use CODE-GEN t
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3418
Thanks for updating, the code looks good to me.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/3418
Hi, @wuchong thanks a lot for your review. I had change the test to
UnitTest.
bests,
SunJincheng
---
If your project is set up for it, you can reply to this email and have your
reply
