[GitHub] flink issue #3426: [FLINK-5414] [table] Bump up Calcite version to 1.11
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3426 Thanks for the update @haohui. I fixed the decimal issues by applying changes from @wuchong's PR. I think for now we should not do the primitive checking for scalar functions, this should be part of FLINK-5177. I will merge this now. But we should definitely solve FLINK-5177 soon. I will assign it to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3426: [FLINK-5414] [table] Bump up Calcite version to 1.11
Github user haohui commented on the issue: https://github.com/apache/flink/pull/3426 @twalthr can you please take another look? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3426: [FLINK-5414] [table] Bump up Calcite version to 1.11
Github user haohui commented on the issue: https://github.com/apache/flink/pull/3426 Fix the unit tests. There are two additional changes: 1. There are precision differences when converting `double` to `BigDecimal`. Fix the unit tests. 2. When registering UDFs Flink needs to distinguish nullable and non-nullable types. Patched `UserDefinedFunctionUtils`. We need a solution like FLINK-5177 to handle these cases systematically. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3426: [FLINK-5414] [table] Bump up Calcite version to 1.11
Github user haohui commented on the issue: https://github.com/apache/flink/pull/3426 Sorry stuck with something. Will update the PR in a day or two. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3426: [FLINK-5414] [table] Bump up Calcite version to 1.11
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3426 @haohui your build is failing. Can you have a look at it again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3426: [FLINK-5414] [table] Bump up Calcite version to 1.11
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3426 Thanks @wuchong and @haohui. I will look at it today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3426: [FLINK-5414] [table] Bump up Calcite version to 1.11
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/3426 Hi @haohui , the code looks very good to me. Thanks for investigating this, waiting for the CI pass. @twalthr , I think you would like to have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
