Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3455
Looks good, thanks.
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/3455
@StephanEwen , I fixed the iteration tests to make it stable yesterday, and
I think it may be related with the static incremental id in
`StreamTransformation`, especially for multi tests to be
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/3455
@StephanEwen , yes, I already noticed that today and this test can pass in
my local machine. And I executed it for many loops and found that it may fail
sometimes because of the sort sequence of
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3455
Seeing some test failures associated with this pull request.
StreamingJobGraphGeneratorTest.testChainedResourceMerging:
-
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3455
Thanks, looks good. Will merge this once the CI builds have passed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/3455
@StephanEwen , I have submitted the modifications as we confirmed before.
It needs to change some previous codes and excuse my late update because of a
little busy last week.
BTW, I found
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3455
Sounds very good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/3455
@StephanEwen , thank you for reviews and suggestions.
I would add the related tests for `JobGraphGenerator` and try to cover
different chained modes.
BTW, I will also remove the
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3455
The code in this PR looks good. Would be nice to have a test for the
merging on the `JobGraphGenerator` side, similar to the one for the
`StreamingJobGraphGenerator`.
A test that checks
