Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3481
Changes look good to me. Will rebase the PR and then merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/3481
@tillrohrmann this was the PR I mentioned to you during flink foward, if
you get a chance to look :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3481
@zentol are you able to get this across the finish line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/3481
@EronWright good suggestion in regards to containerInfo without an image
name, I confirmed in the mesos docs that it should work that way.
Lemme know if there is anything else!
---
If
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/3481
@EronWright @zentol minor bump on this... any other steps to get this on
the path to being merged?
Don't want to let this hang out for too long so I forgot about it :)
---
If your
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/3481
Okay, just moved things around, agree that its a better place, but was
hesitant at first as we were building any other mesos objects earlier.
Hopefully this still works. I think going forwad and
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/3481
@zentol thanks for the quality reviews. The code reads a lot cleaner with
the mode parsing being handled by the enum. My java is pretty rusty after all
being in scala of late :)
I think
Github user addisonj commented on the issue:
https://github.com/apache/flink/pull/3481
@zentol thanks for the review! I think I addressed all those, updated via
an amend. Wasn't sure if you want changes as new commits or not.
Also, the build passed locally for me, but I
