Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3485
Looks good, thanks! Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3485
@StephanEwen
FlatMapFunction "Tokenizer" has move to
org.apache.flink.test.testfunctions.
Help me to review this. Thanks.
And collect other reusable functions to
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3485
OK, get it. So how about just do it now in flink-tests like this pull
request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3485
I don't think it is necessary to unify all example functions. These are
just minimal non critical pieces defined by some tests. One we drop Java 7,
most of them will anyways disappear and become
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3485
@StephanEwen It's a good idea. We can remove many duplicate code in
flink-tests in this way.
But I found it also duplicate in other modules. How to solve it in other
modules.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3485
Would be nice to follow up here and collect also functions like "identity
mapper" or so in that package.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3485
How about we create a package `org.apache.flink.test.testfunctions` where
we collect all shared reusable function implementations?
---
If your project is set up for it, you can reply to this
Github user liuyuzhong7 commented on the issue:
https://github.com/apache/flink/pull/3485
@uce
1. This pull request has squash in one commit.
2. JIRA has set affects version to 1.2.0
Help me to review this code, Thanks.
---
If your project is set up for it, you can
