[GitHub] flink issue #3487: [FLINK-5980] Expose max-parallelism value in RuntimeConte...

2017-03-10 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3487 I think this looks good now, merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #3487: [FLINK-5980] Expose max-parallelism value in RuntimeConte...

2017-03-08 Thread ifndef-SleePy
Github user ifndef-SleePy commented on the issue: https://github.com/apache/flink/pull/3487 Thank you, Stephan and zentol. Good question and suggestion. I didn't consider it too much for batch jobs. Also I think it's a bad idea that naming the variable "numberOfKeyGroups" in

[GitHub] flink issue #3487: [FLINK-5980] Expose max-parallelism value in RuntimeConte...

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3487 For batch jobs, I would suggest that we make sure that the `ExecutionEnvironment` or the `JobGraphGenerator` sets the max parallelism to the parallelism. Then we do not need to differentiate in