Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3587
FYI: I managed to backport the changes (including the contract test
refactorings) back to `release-1.2`.
But since it involved quite a few conflict resolvings, I'm waiting on a
local Travis run
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3587
Thanks @tzulitai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3587
Thanks for merging, @tzulitai! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3587
Merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3587
Thanks a lot for the extra pair of eyes on this @kl0u!
I can fix the typo and proceed to merge this to `master` and `release-1-2`.
---
If your project is set up for it, you can reply to this
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3587
Thanks a lot for addressing my comments @aljoscha!
That's so much cleaner now :-D Really like the refactoring in the fixes.
I actually didn't realize the mock stubs and util methods were
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3587
Thanks for the thorough review, @tzulitai!
And shame over my head for all the code duplication ð±
I now refactored the contract tests into a base class and addressed all the
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3587
@StephanEwen this is the better alternative to #3535 in that it doesn't
silently drop windows and throws an exception when window shrinking occurs.
---
If your project is set up for it, you can
