[GitHub] flink issue #3594: [FLINK-6149] [table] Add additional flink logical relatio...

2017-04-19 Thread DmytroShkvyra
Github user DmytroShkvyra commented on the issue: https://github.com/apache/flink/pull/3594 @KurtYoung, @fhueske This PR violated work with null nodes: ` org.apache.flink.table.api.TableException: Cannot generate a valid execution plan for the given query: LogicalPro

[GitHub] flink issue #3594: [FLINK-6149] [table] Add additional flink logical relatio...

2017-04-18 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/3594 Rebased to master and will merge after build check --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #3594: [FLINK-6149] [table] Add additional flink logical relatio...

2017-04-18 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3594 Hi @KurtYoung, thanks for the update! I think this PR is good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] flink issue #3594: [FLINK-6149] [table] Add additional flink logical relatio...

2017-04-18 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/3594 @fhueske I have rename the package and update the union description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #3594: [FLINK-6149] [table] Add additional flink logical relatio...

2017-04-18 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3594 Thanks for the update @KurtYoung. I'll have a detailed look at the changes later today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink issue #3594: [FLINK-6149] [table] Add additional flink logical relatio...

2017-04-17 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/3594 Hi @fhueske , sorry for taking it so long to update this PR. Looks like it has so many conflicts with master now, once you are ok with all the changes, i will rebase it to master. --- If your