[GitHub] flink issue #3632: [FLINK-6176] [scripts] Add JARs to CLASSPATH deterministi...

2017-04-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3632 Changes look good to me. Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #3632: [FLINK-6176] [scripts] Add JARs to CLASSPATH deterministi...

2017-04-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3632 Updated for YARN @StephanEwen @EronWright --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3632: [FLINK-6176] [scripts] Add JARs to CLASSPATH deterministi...

2017-03-29 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/3632 I believe the `yarn-session.sh` applies to the client-side only (which launches the AM into the cluster). To adjust the classpath for the AM/TM, I believe some adjust is needed here:

[GitHub] flink issue #3632: [FLINK-6176] [scripts] Add JARs to CLASSPATH deterministi...

2017-03-29 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3632 @EronWright this will not fix conflicts but will make debugging easier since the classpath will be consistent across filesystems and Flink installations. We currently have no order to the

[GitHub] flink issue #3632: [FLINK-6176] [scripts] Add JARs to CLASSPATH deterministi...

2017-03-29 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/3632 With respect to making this change for Mesos, look to `mesos-appmaster.sh` and `mesos-taskmanager.sh` which produce the classpath. Those scripts do import `config.sh` but don't use

[GitHub] flink issue #3632: [FLINK-6176] [scripts] Add JARs to CLASSPATH deterministi...

2017-03-29 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3632 @StephanEwen will look at refactoring this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #3632: [FLINK-6176] [scripts] Add JARs to CLASSPATH deterministi...

2017-03-29 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3632 Looks like a good change. Do we want the same deterministic class path order also when launching Yarn and Mesos containers? /cc @rmetzger @EronWright --- If your project is set up for