Github user tony810430 commented on the issue:
https://github.com/apache/flink/pull/3633
Thanks a lot for doing these work. Nice to see this PR be merged. =)
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3633
I finally found the time to look at this.
Have rebased it and applied some simplifications:
- convenience constructors for stateless tasks
- test utils that provide mock
Github user tony810430 commented on the issue:
https://github.com/apache/flink/pull/3633
Hi @StephanEwen
Do you have time recently? Or can we find someone to review it if you are
too busy to do this? Thank you.
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3633
Sorry about the delay. I still have this on my list...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tony810430 commented on the issue:
https://github.com/apache/flink/pull/3633
Hi @StephanEwen
Do you have time to review this PR recently?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user tony810430 commented on the issue:
https://github.com/apache/flink/pull/3633
I see. Thank you. =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3633
Sorry, I did not manage to merge this, yet. Will try to take it on after
the 1.3 release.
Thanks for the offer to rebase that. I can ping you when I would be getting
close to merging this,
Github user tony810430 commented on the issue:
https://github.com/apache/flink/pull/3633
Hi @StephanEwen
Have you been reviewing this PR? If not, I would like to rebase it and fix
those conflicts. What do you think?
---
If your project is set up for it, you can reply to
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3633
Thanks, I will try and look at this over the next week.
It is quite a big change, so I might need a bit of time to review it
properly...
---
If your project is set up for it, you can reply
Github user tony810430 commented on the issue:
https://github.com/apache/flink/pull/3633
@StephanEwen Thanks for the suggestion. I have updated the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3633
Thanks for this refactoring. I had only a quick look so far, but one
thought was that this patch could probably be simplified by making
`triggerCheckpoint()` (and restore / notifyComplete) not
11 matches
Mail list logo
