Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3715
Hi @fhueske, thanks for the reviewing, i have update the pr here for
reviewing, and also create a new pr https://github.com/apache/flink/issues/4266
to merge the commit, once you finish
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3715
Hi @fhueske, sorry for late reply, i have update the pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3715
Hi @rtudoran @fhueske, i have update the pr with the latest interface,
thanks for the reviewing.
Thanks very much.
Yuhong
---
If your project is set up for it, you can reply to this
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3715
Hi @fhueske , i have update a version :).
1. As for how to specify the join case is a stream and stream join,
currently i check through there exist time indicator but not exist such as
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3715
The initial PR should have one commit. Following changes should be put as
commits on top of the initial commit. But you are right, we should update the
contribution guidelines to make this more
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3715
Hi @fhueske, Thanks for your reminding, i'm sorry that i forgot to ping
you. I thought a PR could have only one commit, so i squash them to one, i will
notice that.
Thanks very much.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3715
Hi @hongyuhong, thanks for the update.
Please do not squash update commits into the PR. Otherwise it is not
possible to review individual changes. If you squash commits, I have to check
Github user hongyuhong commented on the issue:
https://github.com/apache/flink/pull/3715
Hi @fhueske , Thanks very much for the review! I have update the pr use
JoinFunction instead of FilterFunction, and i will add more test later.
Thanks very much.
Yuhong
---
If your
