Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3911
Thanks, @tzulitai!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3911
I think this LGTM now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3911
Okay
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3911
Therefore I was waiting for that to get resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3911
I think it is, but I was never sure with all the test timeouts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3911
I think the change is okay to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3911
Scratch that, there is still a problem that the tests sometimes fail
because of
```
org.apache.kafka.clients.consumer.RetriableCommitFailedException: Commit
offsets failed with retriable
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3911
I think the last kinks are now ironed out. Could you please take another
look? (anyone interested)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3911
Oh oh, that's a typo, yes. I can also change to `test-infra`, since we have
several folders that are not maven sub modules already.
---
If your project is set up for it, you can reply to this
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3911
@aljoscha, okay, here the directory is perhaps mistyped `.test-infa`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3911
@greghogan No specific reason, to be honest. I took my inspiration for this
from Beam, where we also have a `.test-infra` directory:
https://github.com/apache/beam. I don't know why we have it
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3911
@aljoscha why a hidden directory?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3911
@rmetzger Yes, the test deletes the log files so that additional tests will
start from a clean slate. I might be able to modify the Flink config so that
each test gets it's own log directory.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3911
I tried it locally, but got some weird results:
```
Found error in log files.
Found exception in log files.
Found non-empty file
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3911
R: @rmetzger for review, please ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
15 matches
Mail list logo
