[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-07-04 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4213 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-07-04 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4213 Just ran into this as well. This was so annoying. Thank you very much for the fix... I spent an hour assuming it was a problem on my side. Merging now... --- If your project is set up for it, you can re

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-07-03 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4213 @aljoscha you merge since you asked first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-07-03 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4213 Ok, now we have to many committers on this. 😅 How will merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-07-03 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4213 LGTM thanks for the PR @pnowojski and for confirming the issue @StefanRRichter and @aljoscha --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-07-03 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4213 I have added one more sentence to the comment inside the pom. @zentol commit message is already quite verbose, but I have improved commit title. --- If your project is set up for it, you can reply

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-07-03 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4213 let's improve the commit message and comment in the pom as to what we're actually doing (overwriting compiler version properties) and why (IntelliJ switching back). --- If your project is set up for

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-07-03 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4213 So +1 to merging this. @greghogan what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-07-03 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4213 I also observed this after I did a fresh import on Flink in the most recent IntelliJ. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-07-03 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4213 I observed similar problems as @pnowojski and the fix helped for me, so +1 from my side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-06-29 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4213 Ops, sorry. I also have bundled 3.3.9 maven version with 2017.1.4 Intellij. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-06-29 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4213 Okay, I am using the latest stable release (2017.1.4) and the bundled version is 3.3.9. Perhaps different versions are shipped for different OS. --- If your project is set up for it, you can reply

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-06-29 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4213 I have the latest version of the Intellij (build in June), and it uses bundled Maven 3.5.9, while my local maven is 3.5.0. For me it replicates 100% times. Touch the pom.xml of some module (by some

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-06-29 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4213 No, that's what I and I assume many other have configured. I'm just surprised that this has not been previously reported and I have not been able to replicate the issue in IntelliJ. --- If your p

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-06-29 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4213 Yes. Should I not do this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

2017-06-28 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4213 Are you using the Maven bundled with IntelliJ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea