[GitHub] flink issue #4356: [FLINK-5486] Fix lacking of synchronization in BucketingS...

2017-10-19 Thread GJL 
Github user GJL commented on the issue:

https://github.com/apache/flink/pull/4356
  
Thanks for your contribution. I have a few questions because the submitted 
code does not match with what the ticket currently says:

From https://issues.apache.org/jira/browse/FLINK-5486:
>The handlePendingFilesForPreviousCheckpoints() call should be enclosed 
inside the synchronization block. Otherwise during the processing of 
handlePendingFilesForPreviousCheckpoints(), some entries of the map may be 
cleared.

I am confused because the submitted code encloses 
`bucketState.pendingFilesPerCheckpoint.clear();` in a synchronized block.

@tedyu Did you run into actual production issues, or did you find the 
problem while reviewing the code? Can you elaborate why the additional 
synchronized block is needed? 


---

[GitHub] flink issue #4356: [FLINK-5486] Fix lacking of synchronization in BucketingS...

2017-10-18 Thread zhangminglei 
Github user zhangminglei commented on the issue:

https://github.com/apache/flink/pull/4356
  
@tedyu I am retesting now..let us wait what will happen.


---

[GitHub] flink issue #4356: [FLINK-5486] Fix lacking of synchronization in BucketingS...

2017-10-10 Thread zhangminglei 
Github user zhangminglei commented on the issue:

https://github.com/apache/flink/pull/4356
  
OKay. Thanks , Ted. Will retest again soon enough./


---

[GitHub] flink issue #4356: [FLINK-5486] Fix lacking of synchronization in BucketingS...

2017-10-10 Thread tedyu 
Github user tedyu commented on the issue:

https://github.com/apache/flink/pull/4356
  
retest this please


---

[GitHub] flink issue #4356: [FLINK-5486] Fix lacking of synchronization in BucketingS...

2017-08-19 Thread zhangminglei 
Github user zhangminglei commented on the issue:

https://github.com/apache/flink/pull/4356
  
triggering now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4356: [FLINK-5486] Fix lacking of synchronization in BucketingS...

2017-08-17 Thread zhangminglei 
Github user zhangminglei commented on the issue:

https://github.com/apache/flink/pull/4356
  
Okay. Ted. I will trigger the QA soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4356: [FLINK-5486] Fix lacking of synchronization in BucketingS...

2017-08-17 Thread tedyu 
Github user tedyu commented on the issue:

https://github.com/apache/flink/pull/4356
  
Run QA again ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4356: [FLINK-5486] Fix lacking of synchronization in BucketingS...

2017-08-03 Thread zhangminglei 
Github user zhangminglei commented on the issue:

https://github.com/apache/flink/pull/4356
  
```
Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 91.985 sec 
<<< FAILURE! - in 
org.apache.flink.test.checkpointing.ExternalizedCheckpointITCase

testExternalizedFullRocksDBCheckpointsStandalone(org.apache.flink.test.checkpointing.ExternalizedCheckpointITCase)
  Time elapsed: 29.976 sec  <<< ERROR!
java.io.IOException: java.lang.Exception: Failed to complete checkpoint
at 
org.apache.flink.runtime.testingUtils.TestingCluster.requestCheckpoint(TestingCluster.scala:399)
at 
org.apache.flink.test.checkpointing.ExternalizedCheckpointITCase.testExternalizedCheckpoints(ExternalizedCheckpointITCase.java:218)
at 
org.apache.flink.test.checkpointing.ExternalizedCheckpointITCase.testExternalizedFullRocksDBCheckpointsStandalone(ExternalizedCheckpointITCase.java:78)
Caused by: java.lang.Exception: Failed to complete checkpoint
at 
org.apache.flink.runtime.testingUtils.TestingJobManagerLike$$anonfun$handleTestingMessage$1$$anon$2.apply(TestingJobManagerLike.scala:375)
at 
org.apache.flink.runtime.testingUtils.TestingJobManagerLike$$anonfun$handleTestingMessage$1$$anon$2.apply(TestingJobManagerLike.scala:358)
at 
org.apache.flink.runtime.concurrent.impl.FlinkFuture$5.onComplete(FlinkFuture.java:272)
at akka.dispatch.OnComplete.internal(Future.scala:247)
at akka.dispatch.OnComplete.internal(Future.scala:245)
at akka.dispatch.japi$CallbackBridge.apply(Future.scala:175)
at akka.dispatch.japi$CallbackBridge.apply(Future.scala:172)
at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:32)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4356: [FLINK-5486] Fix lacking of synchronization in BucketingS...

2017-07-24 Thread tedyu 
Github user tedyu commented on the issue:

https://github.com/apache/flink/pull/4356
  
lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---