[GitHub] flink issue #4391: [FLINK-7258] [network] Fix watermark configuration order

2017-07-25 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/4391 Thanks for the review @zhijiangW and @zentol. Merging this for `1.3` and `master`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #4391: [FLINK-7258] [network] Fix watermark configuration order

2017-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4391 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #4391: [FLINK-7258] [network] Fix watermark configuration order

2017-07-24 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4391 @uce , really good to see this fix. I remembered meeting this problem in our production before and changed the sequence then. --- If your project is set up for it, you can reply to this email and