[GitHub] flink issue #4612: [FLINK-7452] [types] Add helper methods for all built-in ...

2017-12-18 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4612 @fhueske I would merge this later today if there are no objections. ---

[GitHub] flink issue #4612: [FLINK-7452] [types] Add helper methods for all built-in ...

2017-11-13 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4612 @fhueske I updated this PR and added generic parameters as well. ---

[GitHub] flink issue #4612: [FLINK-7452] [types] Add helper methods for all built-in ...

2017-09-25 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4612 Thanks for the review @fhueske. I hope I addressed all your comments. I would not let the other classes extend the Java class. There are multiple differences. E.g. `Either` and `Option` in

[GitHub] flink issue #4612: [FLINK-7452] [types] Add helper methods for all built-in ...

2017-08-29 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4612 @fhueske Feel free to review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #4612: [FLINK-7452] [types] Add helper methods for all built-in ...

2017-08-28 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4612 CC @alpinegizmo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or