[GitHub] flink issue #4767: [FLINK-7738] [flip-6] Create WebSocket handler (server, c...
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/4767 @tillrohrmann do you need a websocket yet? ---
[GitHub] flink issue #4767: [FLINK-7738] [flip-6] Create WebSocket handler (server, c...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4767 Hi @EronWright, yes I think we still need support for web sockets. The first REST based client won't use this but later on we should definitely add this functionality. At the moment we try hard to make Flip-6 feature equivalent to the old distributed architecture and therefore we couldn't make progress here. But once this has been done, we should re-iterate over this PR again. ---
[GitHub] flink issue #4767: [FLINK-7738] [flip-6] Create WebSocket handler (server, c...
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/4767 @tillrohrmann are you still interested in this websocket code for the REST server? Aside from rebasing, any 'must fix' issues here? ---
[GitHub] flink issue #4767: [FLINK-7738] [flip-6] Create WebSocket handler (server, c...
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/4767 I don't much like the use of `RequestBody` and `ResponseBody` here, or even that the WebSocket distinguishes between client and server messages. Honestly a `MessageBody` marker interface may suffice. WDTY? ---
[GitHub] flink issue #4767: [FLINK-7738] [flip-6] Create WebSocket handler (server, c...
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/4767 Updated the description based on the latest PR. ---