[GitHub] flink issue #4877: [FLINK-4877] About SourceFunction extends Serializable

2017-11-22 Thread vim-wj
Github user vim-wj commented on the issue: https://github.com/apache/flink/pull/4877 @greghogan , @StephanEwen ,sorry fo my late reply.I will close this pull request. ---

[GitHub] flink issue #4877: [FLINK-4877] About SourceFunction extends Serializable

2017-11-21 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4877 @vim-wj if you are okay with Stephan's suggestion could you close this pull request? Also, a small note: `FLINK-4877` references a [Jira ticket](https://issues.apache.org/jira/browse/FLINK

[GitHub] flink issue #4877: [FLINK-4877] About SourceFunction extends Serializable

2017-10-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4877 Thanks for opening this pull request. I think it is correct that `SourceFunction` is not required to implement `Serializable`. But I think it does not cause any problems, as far as I know