Github user Aitozi commented on the issue:
https://github.com/apache/flink/pull/4935
Hi, @tzulitai
After i read kafkaConsumer code again, i found that the per partition kafka
lag metric is register in method `FetchManagerMetrics#recordPartitionLag` But
the when the client get
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4935
Hi @Aitozi, sorry for the long delay in relaying back to this PR.
I'm still not convinced that this is a sane solution. For example, what is
a "good" setting for the `KEY_REGISTER_TIMES`
Github user Aitozi commented on the issue:
https://github.com/apache/flink/pull/4935
ping @tzulitai ~
---
Github user Aitozi commented on the issue:
https://github.com/apache/flink/pull/4935
Hi @tzulitai , could you take look at this again :-) ?
---
Github user Aitozi commented on the issue:
https://github.com/apache/flink/pull/4935
update the code according to the comment. ping @tzulitai
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4935
One other side note:
Please squash your commits into a single one, with an appropriate commit
message (you can refer to the other commits in the codebase as a starter).
Github user Aitozi commented on the issue:
https://github.com/apache/flink/pull/4935
cc @zentol @tzulitai please help review the code.
---
