Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4963
@StefanRRichter Thanks! I will
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4963
Alright, I think this looks good to me now. @bowenli86 would you also like
to work on the followup issues that you created?
I will merge this today or tomorrow.
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4963
@StefanRRichter I added a perf benchmarking unit test, you can find the
perf results in both this PR's description and the comment of that test. The
perf improvement is pretty magnificent, between
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4963
@yunfan123 @aljoscha @StefanRRichter feedbacks are appreciated
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4963
@yunfan123 @aljoscha @StefanRRichter feedbacks are appreciated
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4963
@yunfan123 @aljoscha @StefanRRichter I chose the "shallow" simulation.
What do you guys think?
The build failure seems to be because one build profile timed out.
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4963
@aljoscha IIRC there is no class for `StringAppendTESTOperator ` in the
RocksDB Java API. You can only pass a string that is used inside some factory
in the native RocksDB code to
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4963
I don't know if there's a way of retrieving the class behind the
`"stringappendtest"` merge operator. If not, we should just simulate the
behaviour of appending with commas in Java code.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4963
@yunfan123 sorry I can't find where `PredefinedOptions` defines it. Isn't
Flink using RocksDB's `StringAppendTESTOperator` in `RocksDBKeyedStateBackend`?
Hi @aljoscha , do you have
Github user yunfan123 commented on the issue:
https://github.com/apache/flink/pull/4963
Flink use StringAppendOperator as merge operator. It used in
org.apache.flink.contrib.streaming.state.PredefinedOptions.
It use native java method.
Can we use the native method to merge
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4963
Hi @yunfan123 Thanks for the feedback, and I agree with you.
Well, here's the problem: Flink seems to be using the
StringAppendTestOperator as merge operator from RocksDB, which added a
Github user yunfan123 commented on the issue:
https://github.com/apache/flink/pull/4963
In the rocksdb implement, it still use db.merge to add each element to the
rocksdb.
I think we can get the specific MergeOperator class from rocksdb config and
merge the list as a string.
12 matches
Mail list logo
