Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4980
Thanks again for this fix! ð
Could you please close if GitHub doesn't auto-close?
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/4980
I agree! +1 to merge as soon as Travis gives us the green light.
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4980
thanks, I think this is excellent now. ð
I'll merge as soon as travis is green.
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4980
Yes, but I think this is making an assumption about the internal
implementation. If someone changes that the test could break/not test the right
thing anymore.
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4980
There is only one thread dispatching the calls:
```
executor = Executors.newSingleThreadExecutor(
new
DispatcherThreadFactory(TASK_THREADS_GROUP,
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4980
I think waiting on the stop latch might not be enough (in 100 % of cases)
because the other two calls are also asynchronous.
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4980
I addressed the comments. Let's wait for Travis and let me know if
something else needs to be changed.
@aljoscha @kl0u
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4980
These changes look good! ð
I'll wait for travis and then merge.
---
