[GitHub] flink issue #5040: [FLINK-8104][Table API] fixing ROW type value constructor...

2017-12-04 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5040 Thanks for the update @walterddr. I will merge this... ---

[GitHub] flink issue #5040: [FLINK-8104][Table API] fixing ROW type value constructor...

2017-11-28 Thread walterddr
Github user walterddr commented on the issue: https://github.com/apache/flink/pull/5040 Thanks @twalthr for confirming, I will also add in the documentation today then. ---

[GitHub] flink issue #5040: [FLINK-8104][Table API] fixing ROW type value constructor...

2017-11-28 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5040 Thanks. I will have a look at it soon. I think it ok that the Table API is a super set of features in this case. ---

[GitHub] flink issue #5040: [FLINK-8104][Table API] fixing ROW type value constructor...

2017-11-25 Thread walterddr
Github user walterddr commented on the issue: https://github.com/apache/flink/pull/5040 Yes. I think it would also be good to support `row(field, 'literal')` on both SQL and Table API so I added that. Not sure if this is necessary but `row(1, 'foo').get('f0')` is also

[GitHub] flink issue #5040: [FLINK-8104][Table API] fixing ROW type value constructor...

2017-11-23 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5040 @walterddr Yes of course. Having this for the Table API as well would be great. Something like `row(1, "My String")`? ---

[GitHub] flink issue #5040: [FLINK-8104][Table API] fixing ROW type value constructor...

2017-11-22 Thread walterddr
Github user walterddr commented on the issue: https://github.com/apache/flink/pull/5040 Thanks for the prompt review @twalthr . Yeah I think generalizing the codegen part would be great. Also do you think I can put in TableAPI support in this PR as well? I will update the