Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5076
I think it would be fine to start merging things now since the changes are
more isolated than the dependency convergence one.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5076
Not merged yet,
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5076
Is this merged already?
I think the idea is nice, but I would say let's merge this if we have
commitment to follow up on this, meaning fixing the other modules.
We already have
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5076
merging.
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5076
@zentol thanks for your review. I have updated the PR.
`mvn clean verify -Dverbose -pl flink-clients`ï¼No dependency problems
found:
```
[INFO] ---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5076
@zentol , Thanks for your suggestions, i will be very careful to clean up
the dependencies.
I will start with the top modules (not used by other modules), order as
follow:
> âââ
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5076
Hi @greghogan, You're quite right, Thanks for your advice.
For a discussion of this improvement, you can see #4712.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5076
We also have to look out for dependencies that were added to include a
transitive dependency in a fat jar, like we do for reporters/connectors,
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5076
These should generally be pretty safe changes to make IMO, and well worth
it. In particular the undeclared usage of transitive dependencies (that may be
shaded) frequently caused headaches, and
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/5076
`mvn clean verify -pl flink-clients`, No dependency problems found.
> [INFO] --- maven-dependency-plugin:3.0.2:analyze-only (analyze) @
flink-clients_2.11 ---
> [INFO] No dependency
10 matches
Mail list logo
