Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
merging.
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5118
+1
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
After adding kafka09/cassandra, `slf4j-api` and `force-shading` where
included in the jar.
I've added exclusions for these dependencies to the shade-plugin
configuration, as well as for
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5118
Looks good.
Could you double check what gets packaged into the fat jar? In the previous
version, the `slf4j-api` and `jsr305` dependencies ended up in the fat jar,
even though they
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
Updated the PR.
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5118
+1 for the latest suggestion
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
That should work.
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5118
Can't we do what I suggested earlier: don't build a fat jar if you don't
specify the `build-jar` profile. That way you get a very slim jar that has no
dependencies.
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5118
I am unsure here. The warning is nice, but without some exclusions from the
shading phase, we will have many users wich build gigantic jars (happens to me
as well sometimes). Duplicating
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
that's what we're already doing (well technicall yin the `pre-package`
phase).
Thing is that the `package` phase is _always_ executed before `verify`, and
we can't get around that aside from
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5118
Is it possible to print that only in the `package` phase? (or whatever it's
called)
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
Note that the current approach also prints a warning if `mvn verify` is
executed.
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5118
I like it this way, but what do you think, @StephanEwen? Is that a strong
preference for "fail the build"?
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
As for failing the build, I don't like that option, even if I find a way to
do it. We _do not know_ how such a kill-switch would interact with various IDEs
and tools.
What we could do
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
I'll add flink-clients again with a comment.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5118
`flink-core` is a direct dependency due to the usage of the
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5118
Is there a way to fail the build if users do not use the `-Pbuild-jar`
profile? I would assume that right now, at least half of the users build a
mother-of-all-jars that includes all of Flink.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5118
I think that the change of `1.` is actually not necessary. The dependencies
were good in my opinion:
- `flink-core` is not directly needed, because it is a transitive
dependency of
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5118
The comment about "adding to the exclusions" under `a)` is outdated now.
Should we maybe add the shade plugin in the profile, so that users don't
accidentally build a super-fat jar?
19 matches
Mail list logo
