[GitHub] flink issue #5181: [FLINK-8283] [kafka] Fix mock verification on final metho...

2017-12-20 Thread tzulitai 
Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/5181
  
Also FYI: The stalling tests seems to have been fixed (indirectly?) by 
fixing the mocking issue. No failures have occurred anymore over 10 test local 
Travis runs.


---

[GitHub] flink issue #5181: [FLINK-8283] [kafka] Fix mock verification on final metho...

2017-12-20 Thread tzulitai 
Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/5181
  
Making the `AbstractFetcher::commitInternalOffsetsToKafka` non-final just 
for the sake of testing using mocks really is not ideal.

I've opened a new PR #5189 that properly solves this by introducing a 
proper abstraction for offset committing. Closing this PR in favor of the new 
one.


---

[GitHub] flink issue #5181: [FLINK-8283] [kafka] Fix mock verification on final metho...

2017-12-19 Thread tzulitai 
Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/5181
  
I'm not yet certain this fix is the root cause of the stalling tests 
mentioned in https://issues.apache.org/jira/browse/FLINK-8283. It's something I 
stumbled across while investigating the failing tests.

Will run several local Travis runs over a period of time to see if the 
stalling tests still occur.


---